fix(examples/chat): import vitest globals in e2e-overrides spec (unbreak app build / main red)#679
Merged
Merged
Conversation
…eak app build) `tsconfig.app.json` includes `src/**/*.ts` with `types: []`, so the Angular app build type-checks every spec. `e2e-overrides.spec.ts` (added in #677) used ambient `describe`/`it`/`expect`/`afterEach`, which fail under the app build (`TS2304`/`TS2593`) — the bundle never generates, the e2e server never starts, and all 4 `examples/chat` e2e shards time out. Matches the existing specs by importing the globals from vitest explicitly. Regressed main at 3c45540 (#677 merge); local `nx test` masked it because only `nx serve`/the app build compiles specs under tsconfig.app.json. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hotfix — main is red at
3c45540f(#677 merge)examples/chattsconfig.app.jsonincludessrc/**/*.tswithtypes: [], so the Angular app build type-checks every spec.e2e-overrides.spec.ts(added in #677) used ambientdescribe/it/expect/afterEach:nx test(vitest) masked it locally — only the app build (nx serve) compiles specs undertsconfig.app.json. Fix: import the globals fromvitestexplicitly, matching every existing spec.Verified:
nx build examples-chat-angularnow completes (was failing).🤖 Generated with Claude Code